Differential D871

Move UpdateMode away from MessageViewer::Viewer into MessageViewer namespace
ClosedPublic
Actions

Authored by knauss on Jan 27 2016, 5:15 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Maniphest Tasks
T1223: split objecttreeparer out of messageviewer
Commits
R94:8117adbf1e3f: Move UpdateMode away from MessageViewer::Viewer into MessageViewer namespace
Summary

Need to update kdepim & kdepim-addons

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 2121.Jan 27 2016, 5:15 PM
knauss retitled this revision from to Move UpdateMode away from MessageViewer::Viewer into MessageViewer namespace.
knauss updated this object.
knauss added a reviewer: mlaurent.
knauss added a task: T1223: split objecttreeparer out of messageviewer.
mlaurent edited edge metadata.Jan 28 2016, 5:52 AM

You change api => change messageviewer version and create patch for kdepim/kdepim-addons.
Regards

knauss added a comment.Jan 28 2016, 11:24 AM
In D871#16955, @mlaurent wrote:

You change api => change messageviewer version and create patch for kdepim/kdepim-addons.
Regards

that is alread on my todo list.

knauss updated this revision to Diff 2144.Jan 29 2016, 6:26 PM
knauss edited edge metadata.

Also push the chagnes to kdepim and kdepim-addons.

See D885 & D886

mlaurent accepted this revision.Jan 31 2016, 5:55 PM
mlaurent edited edge metadata.

seems ok

This revision is now accepted and ready to land.Jan 31 2016, 5:55 PM
knauss added inline comments.Jan 31 2016, 7:11 PM
messageviewer/src/viewer/nodehelper.h
52

What about to move this enum to a own file, that we would get rid of adding KF5::IconsTheme everywhere?
And we may end up adding more enums there, within the split to libotp.

knauss updated this revision to Diff 2164.Feb 1 2016, 3:44 PM
knauss edited edge metadata.

use enums.h now

mlaurent added a comment.Feb 2 2016, 3:51 PM

I think that you forgot to install enum.h no ?
otherwise it will not work with kdepim-addons and co

knauss added a comment.Feb 2 2016, 6:34 PM
In D871#17280, @mlaurent wrote:

I think that you forgot to install enum.h no ?
otherwise it will not work with kdepim-addons and co

Yes you are right - but all CMakeLists foo is done in D873, but I havn't pushed the newsest version with Enum been installed:

@@ -301,6 +333,7 @@ ecm_generate_headers(MessageViewer_Camelcaseviewer_HEADERS
   Stl_Util
   CSSHelperBase
   MessagePart
+  Enums
   REQUIRED_HEADERS MessageViewer_viewer_HEADERS
   PREFIX MessageViewer
   RELATIVE viewer
Closed by commit R94:8117adbf1e3f: Move UpdateMode away from MessageViewer::Viewer into MessageViewer namespace (authored by knauss). · Explain WhyFeb 3 2016, 5:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2176

View Options

CMakeLists.txt

Loading...
View Options

messageviewer/autotests/CMakeLists.txt

Loading...
View Options

messageviewer/autotests/unencryptedmessagetest.cpp

Loading...
View Options

messageviewer/src/header/contactdisplaymessagememento.h

Loading...
View Options

messageviewer/src/header/contactdisplaymessagememento.cpp

Loading...
View Options

messageviewer/src/viewer/enums.h

Loading...
View Options

messageviewer/src/viewer/memento/cryptobodypartmemento.h

Loading...
View Options

messageviewer/src/viewer/nodehelper.h

Loading...
View Options

messageviewer/src/viewer/objecttreeparser.cpp

Loading...
View Options

messageviewer/src/viewer/urlhandlermanager.cpp

Loading...
View Options

messageviewer/src/viewer/viewer.h

Loading...
View Options

messageviewer/src/viewer/viewer.cpp

Loading...
View Options

messageviewer/src/viewer/viewer_p.h

Loading...
View Options

messageviewer/src/viewer/viewer_p.cpp

Loading...