messageviewer/src/CMakeLists.txt
87–118	Why not move file in subdirectory ? to avoid to create "2" project in same directory ?
88	Duplicate file list ? Why not create messageviewer which depend against otp ?
521	Why not camelcase as other file ?
547	same debug log ?

messageviewer/src/CMakeLists.txt
87–118	In the first step i simply want to create libotp alongside with messageviewer. So libotp can be used right away and I can do hacks like for the urlmanager. My plan is like this: cleanup libotp till it is usable for kube (I have additionaly ~10 patches, that I need to upsteam) make messageviewer depend on libotp (than things like the urlmaanager thing needs to be reworked, tests need to move etc.), change logging category,... I think this way i need less patches to get libopt compileable and it is easier to review. Because filemoves are hard to follow, if also changes are done in the files.
521	good point :D
547	becuase we create libotp alongside with messageviewer we can't use different logging categories at the moment.

Added MimeType in the CamelCase header

Forgotten to remove unneeded line.

seems good

This revision is now accepted and ready to land.Jan 30 2016, 12:25 PM

now with Enum been installed

This revision was automatically updated to reflect the committed changes.

		Path
M		messageviewer/CMakeLists.txt (28 lines)
A	M	messageviewer/KF5OtpConfig.cmake.in (7 lines)
M		messageviewer/src/CMakeLists.txt (75 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2123	946e631		Jan 27 2016, 5:18 PM	★	★
Diff 2	2140	e1f8ac0	Added MimeType in the CamelCase header	Jan 29 2016, 4:03 PM	★	★
Diff 3	2141	e1f8ac0	Forgotten to remove unneeded line.	Jan 29 2016, 4:15 PM	★	★
Diff 4	2169	cc3a6ed	now with Enum been installed	Feb 2 2016, 6:35 PM	★	★
Diff 5	2178	cc3a6ed	rMESSAGELIB131fe40fc4a9856c7f22a02395b5de2982969e49	Feb 1 2016, 3:29 PM	★	★

Create libotp as complete library
ClosedPublic
Actions

Details