KDesktopFile::sortOrder() returns the value of SortOrder key
as a string whithout parsing it as a list.
But according to Desktop Entry Specification
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
it's type is "string(s)", i.e. the same type as the type of
Actions and MimeType keys, and thus it should be read the same way.
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R237:d328dd6ac725: Fix the result of KDesktopFile::sortOrder()
Diff Detail
Diff Detail
- Repository
- R237 KConfig
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This looks correct, but did you find the KDE code that writes out this key?
A quick LXR search doesn't find anything relevant; do we use this feature at all?
https://lxr.kde.org/search?_filestring=&_string=%22SortOrder%22&_casesensitive=1
Comment Actions
Well, at first I was planning to use this method in my project, but since it's not used in KDE
and besides the SortOrder key is deprecated, I guess that KDesktopFile::sortOrder() should be
marked as deprecated.
The question is whether to fix it first?
Comment Actions
I don't really mind/care if it's fixed or not, if it's deprecated and unused :-)
Want to submit a patch to deprecate it?