Screenlocker KCM text improvements
ClosedPublic
Actions

Authored by ngraham on Nov 6 2017, 9:29 PM.

Details

Reviewers

Group Reviewers

VDG
Plasma

Commits

R133:dd3722248e20: Screenlocker KCM text improvements

Summary

BUG: 386573

Test Plan

Tested in KDE Neon:

Repository

R133 KScreenLocker

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham edited the test plan for this revision. (Show Details)Nov 6 2017, 9:29 PM

apol added inline comments.

kcm/kcm.ui
131	Maybe leave it at `keyboard shortcut`? `Lock screen` is a bit redundant as we're already at the screen locking page and the text seems long.

Make this string shorter

I would agree, keyboard shortcut seems better. It just felt like the label didn't have context for the shortcut button next to it.

This revision is now accepted and ready to land.Nov 7 2017, 12:37 AM

ngraham marked an inline comment as done.Nov 7 2017, 12:37 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcm/kcm.ui (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22001	b6bca90		Nov 6 2017, 9:29 PM	★	★
Diff 2	22011	b6bca90	Make this string shorter	Nov 7 2017, 12:35 AM	★	★
Diff 3	22012	b6bca90	R133:dd3722248e20a1c44c0e30f57d8a801e010b5c26	Nov 7 2017, 12:20 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a8de10319f0c	7fc44bef5d07	b6bca90c6350	Nathaniel Graham	Screenlocker KCM text improvements (Show More…)	Nov 6 2017, 9:28 PM