ClosedPublic
Actions

Authored by staniek on Jan 27 2016, 12:04 PM.

Details

Reviewers

Maniphest Tasks

Commits

Summary

<SELECT "a" + "b"> parses in Kexi>=2.9.7 but results in invalid (boolean) type/value
for convenience, if either argument is of text type, operator "+" is now assumed to be identical to operator ||
also fix SELECT "a" || "b" for MySQL (using CONCAT() is needed)

Test Plan

Try test queries from the project attached at https://bugs.kde.org/show_bug.cgi?id=358636.
Try other queries that use text columns instead of string constants.

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

staniek retitled this revision from to Kexi: Make <SELECT "a" + "b"> SQL queries work and fix <SELECT "a" || "b">.

staniek updated this object.

staniek edited the test plan for this revision. (Show Details)

staniek added reviewers: piggz, wicik.

Any tests for this feature?

@piggz Yes please see the "Test Plan" section above :)

i meant an auto-test

In D867#17130, @piggz wrote:

i meant an auto-test

Yes, after porting to KDb it will be easy to add some. In KDb SQL autotests can use plain text files:

autotests/parser/data/statements.txt

piggz edited edge metadata.

This revision is now accepted and ready to land.Jan 29 2016, 7:42 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kexi/kexidb/drivers/mysql/mysqldriver.h (7 lines)
M			kexi/kexidb/drivers/mysql/mysqldriver.cpp (9 lines)
M			libs/db/driver.h (11 lines)
M			libs/db/driver.cpp (7 lines)
M			libs/db/expression.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2117	a454c7b		Jan 27 2016, 12:04 PM	★	★
Diff 2	2148	4efe8f2	rCALLIGRA2bb05472bca81d13565cf9501ae04589d38e00a4	Jan 29 2016, 7:43 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
984f4e957333	23c43008a51c	a454c7b3cd56	Jaroslaw Staniek	Kexi: Make <SELECT "a" + "b"> SQL queries work and fix <SELECT "a" \|\| "b"> (Show More…)	Jan 27 2016, 11:36 AM