Ignore unrecognized files in CompilerProvider
ClosedPublic

Authored by aaronpuchert on Nov 4 2017, 6:37 PM.

Details

Summary

Sometimes the compiler provider is called on files that we don't
compile. Instead of complaining, we just return an empty set of includes
or defines.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aaronpuchert created this revision.Nov 4 2017, 6:37 PM
mwolff accepted this revision.Nov 6 2017, 12:28 PM
mwolff added a subscriber: mwolff.

lgtm, but you can simplify the code by writing return {}; in both places. Also, it doesn't hurt to add a short comment saying something like you do in your commit message

This revision is now accepted and ready to land.Nov 6 2017, 12:28 PM
This revision was automatically updated to reflect the committed changes.