Remove DataModel::roleNameToId
ClosedPublic
Actions

Authored by broulik on Nov 3 2017, 10:49 AM.

Details

Reviewers

mwolff

Group Reviewers

Plasma

Commits

R242:d51456bdfcbd: Remove DataModel::roleNameToId

Summary

It is unused and returned -1 whereas SortFilterModel would return Qt::DisplayRole

Test Plan

This class is not exported but only part of the corebindingsplugin so this method can be removed

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Nov 3 2017, 11:20 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarativeimports/core/datamodel.h (2 lines)
M			src/declarativeimports/core/datamodel.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21831			Nov 3 2017, 10:48 AM	★	★
Diff 2	21965	7ec2ccb	R242:d51456bdfcbd86c150ea3e0df699f9d2303b7313	Nov 6 2017, 2:17 PM	★	★