Differential D863

Deal with the bug introduced in KCalCore
ClosedPublic
Actions

Authored by ervin on Jan 26 2016, 10:55 PM.

Details

Reviewers
mlaurent
bensi
dfaure
franckarrecot
Commits
R4:420b0c6db3ec: Deal with the bug introduced in KCalCore
Summary

This will get fixed when KCalCore 4.83 will be out, but for the time
being work around it in the test. This is not completely essential for
us.

CCMAIL: montel@kde.org

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 2111.Jan 26 2016, 10:55 PM
ervin retitled this revision from to Deal with the bug introduced in KCalCore.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, dfaure, mlaurent.
mlaurent accepted this revision.Jan 27 2016, 5:41 AM
mlaurent edited edge metadata.
mlaurent added inline comments.
tests/testlib/akonadistoragetestbase.cpp
772

I don't know how work QEXPECT_FAIL it will continue for when before line fail or for next line after qexpect_fail ?

otherwise the last line will failed too no ?

This revision is now accepted and ready to land.Jan 27 2016, 5:41 AM
mlaurent added a comment.Jan 27 2016, 5:41 AM

Oh I didn"t want to accept before to have an answer for my comment :)

ervin added inline comments.Jan 27 2016, 6:10 AM
tests/testlib/akonadistoragetestbase.cpp
772

It is for the next line after QEXPECT_FAIL. So that QCOMPARE won't give us a FAIL when the bug is present.

mlaurent added a comment.Jan 27 2016, 8:37 AM

Ok so ship it :)

bensi accepted this revision.Jan 27 2016, 8:39 AM
bensi edited edge metadata.
Closed by commit R4:420b0c6db3ec: Deal with the bug introduced in KCalCore (authored by ervin). · Explain WhyFeb 9 2016, 8:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2236

View Options

tests/testlib/akonadistoragetestbase.cpp

Loading...