The filter format demanded by QFileDialog is different from KFileDialog.
Also, the filter returned is just the filter combobox text verbatim.
Details
Details
- Reviewers
dfaure - Commits
- R228:524709e90ece: Fix Save As feature
I can now save searches as html files and txt files properly.
Diff Detail
Diff Detail
- Repository
- R228 KFind
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Fix placeholder (use %1 always)
- Remove space between label and filter so it doesn't have a trailing space in the filter dropdown
Comment Actions
You should prefer mimetype filters, so that more extensions and magic-mimetype-determination works.
text/html and text/plain should do the job just fine, no?
Comment Actions
For mime type filters I cannot use getSaveFileUrl, can I? I tried `text/html;;text/plain` as filter` but that doesn't work, so I probably have to create a QFileDialog myself.
Comment Actions
- Use mime type filters
(This requires Qt 5.9, is this safe for Applications master? @aacid )
Comment Actions
My definition of KDE Applications is that they can have whatever dependency they want/need.
| src/kfindtreeview.cpp | ||
|---|---|---|
| 449 | Are we 100% sure that selecting a URL and then clicking Cancel will lead to selectedUrls() being empty? I would test the return value of exec(), to be sure to handle Cancel correctly. | |