Differential D8608

Fix crash in KAStatsFavouritesModel
ClosedPublic
Actions

Authored by davidedmundson on Nov 1 2017, 11:39 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:6e1ae0539c4e: Fix crash in KAStatsFavouritesModel
R120:615f6ac12753: Fix crash in KAStatsFavouritesModel
Summary

KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
of the KAStatsFavouritesModel, like the name implies.

It is set in initForClient.

If the activity changes before we have a client ID, there's no point
doing anything and trying to use the clientID will crash.

BUG: 386439

Test Plan

None.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 1 2017, 11:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 1 2017, 11:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni added a subscriber: anthonyfieroni.Nov 2 2017, 4:55 AM
anthonyfieroni added inline comments.
applets/kicker/plugin/kastatsfavoritesmodel.cpp
506

d && d->trigger ?

625

addFavorite has a check, so here it should.

641

dito

662

dito

davidedmundson updated this revision to Diff 22111.Nov 9 2017, 9:06 AM
davidedmundson marked 4 inline comments as done.

Update

hein accepted this revision.Nov 9 2017, 12:34 PM
This revision is now accepted and ready to land.Nov 9 2017, 12:34 PM
Closed by commit R119:6e1ae0539c4e: Fix crash in KAStatsFavouritesModel (authored by davidedmundson). · Explain WhyNov 13 2017, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22257

View Options

applets/kicker/plugin/kastatsfavoritesmodel.cpp

Loading...