get rid of objectTreeParser()->showOnlyOneMimePart()
ClosedPublic
Actions

Authored by knauss on Oct 31 2017, 1:31 PM.

Details

Reviewers

Commits

Summary

the showOnlyOneMimePart setting is strange and mostly unused
in objecttreeparser. Only used once at processing and later needed for the renderer.

Test Plan

run tests

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

mimetreeparser/src/bodypartformatter.cpp
126	This is now dead code.
mimetreeparser/src/messagepart.h
70–71	remove commented out code?

Soory I forgotten to mark this as WIP - I found out, that showOnlyOneMimePart() is not always false, so I need to refactor this.

delete isHidden directly.

should remove all commented code now together with D8620 and D8621.

now this one is no WIP and ready for final review.

This revision is now accepted and ready to land.Nov 13 2017, 6:09 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			messageviewer/src/viewer/viewer_p.cpp (6 lines)
M			mimetreeparser/src/bodyformatter/applicationpgpencrypted.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/textplain.cpp (1 line)
M			mimetreeparser/src/bodypartformatter.cpp (4 lines)
M			mimetreeparser/src/messagepart.h (8 lines)
M			mimetreeparser/src/messagepart.cpp (12 lines)
M			mimetreeparser/src/objecttreeparser.h (9 lines)
M			mimetreeparser/src/objecttreeparser.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21640	2c86497		Oct 31 2017, 1:31 PM	★	★
Diff 2	21780	0893d4c	delete isHidden directly.	Nov 2 2017, 3:08 PM	★	★
Diff 3	22353	035cbe2	R94:e5c508e56e266f7327776c779cb4b922cec301e1	Nov 14 2017, 2:42 PM	★	★