Differential D8570

Move attachment handling to renderer.
ClosedPublic
Actions

Authored by knauss on Oct 31 2017, 1:28 PM.

Details

Reviewers
vkrause
Commits
R94:59a75d7bae75: Move attachment handling to renderer.
Summary

AttachmentStrategy is a part of the Renderer and not of the Parsing.

Test Plan

run tests

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Oct 31 2017, 1:28 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 31 2017, 1:28 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
vkrause added inline comments.Oct 31 2017, 5:56 PM
mimetreeparser/src/messagepart.h
231

remove commented out code?

knauss marked an inline comment as done.Nov 2 2017, 3:16 PM
knauss added inline comments.
mimetreeparser/src/messagepart.h
231

removed in D8573.

vkrause accepted this revision.Nov 13 2017, 6:10 PM
This revision is now accepted and ready to land.Nov 13 2017, 6:10 PM
Closed by commit R94:59a75d7bae75: Move attachment handling to renderer. (authored by knauss). · Explain WhyNov 14 2017, 3:42 PM
This revision was automatically updated to reflect the committed changes.
knauss marked an inline comment as done.

Revision Contents
Changeset List

Diff 22350

View Options

messageviewer/src/messagepartthemes/default/defaultrenderer.h

Loading...
View Options

messageviewer/src/messagepartthemes/default/defaultrenderer.cpp

Loading...
View Options

messageviewer/src/messagepartthemes/default/defaultrenderer_p.h

Loading...
View Options

messageviewer/src/messagepartthemes/default/messagepartrendererbase.h

Loading...
View Options

messageviewer/src/messagepartthemes/default/plugins/attachmentmessagepartrenderer.cpp

Loading...
View Options

messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.cpp

Loading...
View Options

messageviewer/src/viewer/objecttreeemptysource.h

Loading...
View Options

messageviewer/src/viewer/objecttreeemptysource.cpp

Loading...
View Options

messageviewer/src/viewer/objecttreeviewersource.h

Loading...
View Options

messageviewer/src/viewer/objecttreeviewersource.cpp

Loading...
View Options

mimetreeparser/autotests/setupenv.h

Loading...
View Options

mimetreeparser/src/interfaces/objecttreesource.h

Loading...
View Options

mimetreeparser/src/messagepart.h

Loading...
View Options

mimetreeparser/src/messagepart.cpp

Loading...