Kexi: Fix state of 'modification' flag while switching from SQL view to Query Data view and back
ClosedPublic

Authored by staniek on Jan 23 2016, 10:36 AM.

Details

Summary

A general change in the logic of the Query Designer is that now we remember the view mode that was in use while the modification to design happened, not just the fact that the modification happened previously (since the last saving changes).

BUG:278379

Also fixes this:
Changes in query design not retained after changes in SQL view and switching to Data view
BUG:358413

FIXED-IN:2.9.11

Test Plan

Follow the scenarios of the both bugs for any simple query such as "SELECT * FROM T ORDER BY F".

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek updated this revision to Diff 2072.Jan 23 2016, 10:36 AM
staniek retitled this revision from to Kexi: Fix state of 'modification' flag while switching from SQL view to Query Data view and back.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added reviewers: piggz, wicik.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptJan 23 2016, 10:36 AM
staniek updated this revision to Diff 2077.Jan 23 2016, 7:12 PM

Update condition for KexiQueryDesignerSQLView::afterSwitchFrom

staniek updated this revision to Diff 2078.Jan 23 2016, 7:13 PM

fix buggy update

wicik edited edge metadata.Jan 27 2016, 8:40 PM

Against which repository this patch should be applied?
it doesn't work against kexi (git.kde.org/kexi).

is it against callgra repository?

In D856#16887, @wicik wrote:

Against which repository this patch should be applied?
it doesn't work against kexi (git.kde.org/kexi).

is it against callgra repository?

calligra.git, please always look at Diff Detail on the top:

Repository
   rCALLIGRA Calligra

All the fixes go to 2.9.*, I think forward ports will go without reviews or with at most with audits.

staniek edited edge metadata.Jan 27 2016, 9:05 PM
staniek removed a project: Calligra: 3.0.

BTW, the Project == Kexi but this does not mean the repo is always kexi.git, as long as we still develop for caligra.git too.

OK, @piggz @wicik @wkosowicz @kpawlowski I am pushing the patch, please perform audit based on Test Plan above. Ideally on Saturday. Thanks!

This revision was automatically updated to reflect the committed changes.