Differential D8545

kio: fix handling of KCookieAdvice::AcceptForSession
ClosedPublic
Actions

Authored by schwab on Oct 29 2017, 2:19 PM.

Details

Reviewers
dfaure
Summary

Commit 23874cab9d broke the handling of KCookieAdvice::AcceptForSession
because strToAdvice(adviceToStr(KCookieAdvice::AcceptForSession)) now
returns KCookieAdvice::Dunno. Ignore spaces in the argument of
strToAdvice to properly recognize the AcceptForSession setting and restore
compatibility with previous configs.

BUG: 386325

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
schwab created this revision.Oct 29 2017, 2:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 29 2017, 2:19 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure requested changes to this revision.Oct 29 2017, 3:33 PM
dfaure added inline comments.
src/kcms/kio/kcookiespolicyselectiondlg.h
54

Oh, nasty, the kconfig key is the untranslated english message...

OK with the fix, except that you probably meant remove(' ').
I don't even see how replace(' ') can compile, all replace overloads take at least two args, no?

This revision now requires changes to proceed.Oct 29 2017, 3:33 PM
schwab updated this revision to Diff 21528.Oct 29 2017, 4:27 PM

Accidentally attached the wrong diff

dfaure accepted this revision.Oct 29 2017, 5:15 PM
This revision is now accepted and ready to land.Oct 29 2017, 5:15 PM
wbauer added a subscriber: wbauer.Dec 10 2017, 2:18 AM

Has this been forgotten?
It should be committed by somebody, I think...

FYI, we do have this patch in openSUSE for a while.
https://bugzilla.opensuse.org/show_bug.cgi?id=1049975

Also there is:
https://bugs.kde.org/show_bug.cgi?id=374931

Revision Contents
Changeset List

Diff 21528

View Options

src/kcms/kio/kcookiespolicyselectiondlg.h

Loading...