Add templates for Akonadi resource and serializer plugins
ClosedPublic

Authored by kossebau on Oct 28 2017, 11:35 AM.

Details

Summary

Overhauled versions of the templates from kapptemplate.

Keeping the template with the sources they are based on
helps both discovery and also maintenance.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Oct 28 2017, 11:35 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 28 2017, 11:35 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

Follows the templates for krunner, plasma & ktexteditor, which also have been moved from kapptemplate to the frameworks sources.

Big plan is to have all templates moved from kapptemplate to the respective sources, and at the end of the day turn kapptemplate into a framework lib (and some util apps), which then allows kdevelop, kate & co. to share the from-template-generation code. And each library/framework would provide and maintain their own templates together with the sources.

kossebau updated this revision to Diff 21484.Oct 28 2017, 11:46 AM

add missing ExtraDesktop.sh file

mlaurent added inline comments.Oct 28 2017, 2:27 PM
templates/akonadiresource/CMakeLists.txt
6

5.13.0 ? it seems very old

17

5.3.0? all kdepim depend against 5.8.0 => 5.3.0...

templates/akonadiserializer/CMakeLists.txt
6

5.13.0? qt 5.3.0 ?

I have simply kept the min versions as used with the original templates in kapptemplate.

Motivation has been:
people who use the templates from their current latest kdepim installation still might want to create plugins and share them resp. co-develop which others who have some older kdepim around.

And the code created from the templates themselves does not require latest kdepim.

Does that make sense? Or do you want some certain more recent version as default?

5.3.0 for sure perhaps kdepim 5.0 compiles against but not sure that other kdepim version build against it.
And all distro provides qt5.6.0 but default so 5.3.0 seems too old for a template for sure.

kossebau updated this revision to Diff 21501.Oct 28 2017, 4:49 PM

bump min versions to state april 2016

5.3.0 for sure perhaps kdepim 5.0 compiles against but not sure that other kdepim version build against it.
And all distro provides qt5.6.0 but default so 5.3.0 seems too old for a template for sure.

I have seen some still looking at ubuntu 16.04 lts, where Qt is 5.5 without further ppas. But as you prefer, you know resp. define your target developer audience :)

mlaurent accepted this revision.Oct 29 2017, 7:43 AM

Seems ok for me

This revision is now accepted and ready to land.Oct 29 2017, 7:43 AM
This revision was automatically updated to reflect the committed changes.