Copy SDC 2.0 from KReport and update all files that use it
ClosedPublic

Authored by staniek on Jan 22 2016, 8:28 PM.

Details

Summary

(SDC grammar changed)

Test Plan

Just clearn rebuild, also look for warnings, strange bits of code.
I do admit the generated code could look better but optionally we could astyle or clang-format it afterwards for the best results ;)

Diff Detail

Repository
R15 KDb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek updated this revision to Diff 2067.Jan 22 2016, 8:28 PM
staniek retitled this revision from to Copy SDC 2.0 from KReport and update all files that use it.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added reviewers: wicik, piggz.
Restricted Application added a project: KDb. · View Herald TranscriptJan 22 2016, 8:28 PM
wicik accepted this revision.EditedJan 22 2016, 9:18 PM
wicik edited edge metadata.

Technically correct, configures, compiles without errors (Kexi also), but there are few new things, just to make sure we notice them.
This new SDC script adds

  • 'virtual ~Data()' destructor
  • 'clone()' to the internal data object.
This revision is now accepted and ready to land.Jan 22 2016, 9:18 PM
In D853#16474, @wicik wrote:

This new SDC script adds

  • 'virtual ~Data()' destructor
  • 'clone()' to the internal data object.

Yes, this stuff is for completeness. Thanks for the review!

This revision was automatically updated to reflect the committed changes.