| davidedmundson |
| Plasma |
add a background in scrollview similar to what qwidget's scrollviews do
hide it by default since is not something that seems much in line with qqc2
the api to show it would be scrollview.background.visible = true
which is not really public/nice but it would work without adding extra api
tested with the new design of qml kcms
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
In general ++. The frame is useful for keyboard focus indication if nothing else.
| org.kde.desktop/ScrollView.qml | ||
|---|---|---|
| 47 | As in a textedit? The QQC1 code used "frame" which is semantically more appropriate. Did you do this to get the white background? In QWidgets a scrollarea is transparent, and an itemview is white. I think we might need some way (extra Kirigami class ?) to have both. I suggest holding out on merging till we do a bit more KCM porting and figure that out. | |
| 82 | :D maybe don't find and replace this | |
so, may be worth to have in kirigami a component called like ItemScrollView intended for this?
so, may be worth to have in kirigami a component called like ItemScrollView intended for this?
I think so.
The component can be just one line of ScrollView{}, and the styles can do something like
if typeOf(control) == "ItemView"
Also we shoudn't use "edit" as the elementType for something that's not a textedit now that we control the C++ classes.
hmm, tough if is in Kirigami i can't really use the desktop style private plugin to paint it, or would be cross dependency?
if typeOf(control) == "ItemView"
afaik typeof doesn't work there, all qml item will just return "Object", so the only way is to testing the presence of some properties and hope it goes well :/
tried a version which provides its own component in the kcm controls for the background problem, still not happy about it.
https://phabricator.kde.org/D8692
Can you throw in a tonne of documentation explaining why things are being done the way they are.
