Port kded plugin to json metadata
ClosedPublic
Actions

Authored by heikobecker on Jan 21 2016, 6:25 PM.

Details

Reviewers

plasma-devel
arichardson

Commits

R109:5fd327369bc6: Port kded plugin to json metadata

Repository

R109 KWriteD

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

heikobecker retitled this revision from to Port kded plugin to json metadata.

heikobecker updated this object.

heikobecker edited the test plan for this revision. (Show Details)

arichardson added inline comments.

CMakeLists.txt
78	Add SERVICE_TYPES kdedmodule.desktop here to ensure that all keys have the right type
81	Could be simplified to use `kcoreaddons_add_plugin(kded_kwrite SOURCES kwrited.cpp JSON "kwrited.json" INSTALL_NAMESPACE "kf5/kded")`

Used suggested kcoreaddons_add_plugin

Looks good to me once the JSON has been changed to use bool

kwrited.json
154 ↗	(On Diff #2062)	This and the following should be a boolean not a string. `desktoptojson -s kdedmodule.desktop -i $in -o $out` should correctly do that

This revision is now accepted and ready to land.Jan 23 2016, 5:04 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (6 lines)
M			kwrited.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2058	43bb12e		Jan 21 2016, 6:25 PM	★	★
Diff 2	2062	43bb12e	Used suggested kcoreaddons_add_plugin	Jan 22 2016, 8:58 AM	★	★
Diff 3	2081	43bb12e	rKWRITED5fd327369bc664b99734136af3911b9bf0e87593	Jan 24 2016, 10:49 AM	★	★