kdevplatform: less auto-casting from/to ascii & from bytearray

Authored by kossebau on Oct 27 2017, 7:29 AM.



kdevplatform/language/duchain/stringhelpers.cpp does not build though yet,
has some templates used both for qbytearray and qstring, which relies on
the otherwise hidden constructors

Diff Detail

R32 KDevelop
No Linters Available
No Unit Test Coverage
kossebau created this revision.Oct 27 2017, 7:29 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 27 2017, 7:29 AM
kfunk added a subscriber: kfunk.Oct 27 2017, 8:34 AM

LGTM (only had a relatively quick look)


Is this needed? Isn't it set by the parent CMakeLists.txt?

kossebau marked an inline comment as done.Oct 27 2017, 9:28 AM

So as discussed on irc, will not discard this then, but see to turn this into something all maintainers agree on (and see how to get stringhelper.cpp solved)

Will prepare next some Best Practices Rules for qt string handling code (whether using QStringLiteral or QLatin1String in qstringbuilder-powered concatenations, how to avoid .data duplication when using same qstringliterals, etc) to put in some CODING,md file, so we have some golden rules around which should help to reduce the current random approaches. If good enough perhaps also could be moved to kde wikis for shared usage.


Good catch. Forgot to remove again, left-over from incrementally extending setting those defs.

kfunk accepted this revision.Oct 30 2017, 12:23 PM
This revision is now accepted and ready to land.Oct 30 2017, 12:23 PM
kossebau closed this revision.Oct 30 2017, 4:01 PM
kossebau marked an inline comment as done.