kdevplatform/language/duchain/stringhelpers.cpp does not build though yet,
has some templates used both for qbytearray and qstring, which relies on
the otherwise hidden constructors
Details
Diff Detail
- Repository
- R32 KDevelop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
LGTM (only had a relatively quick look)
kdevplatform/tests/CMakeLists.txt | ||
---|---|---|
1 | Is this needed? Isn't it set by the parent CMakeLists.txt? |
So as discussed on irc, will not discard this then, but see to turn this into something all maintainers agree on (and see how to get stringhelper.cpp solved)
Will prepare next some Best Practices Rules for qt string handling code (whether using QStringLiteral or QLatin1String in qstringbuilder-powered concatenations, how to avoid .data duplication when using same qstringliterals, etc) to put in some CODING,md file, so we have some golden rules around which should help to reduce the current random approaches. If good enough perhaps also could be moved to kde wikis for shared usage.
kdevplatform/tests/CMakeLists.txt | ||
---|---|---|
1 | Good catch. Forgot to remove again, left-over from incrementally extending setting those defs. |