kdevplatform: less auto-casting from/to ascii & from bytearray
ClosedPublic
Actions

Authored by kossebau on Oct 27 2017, 7:29 AM.

Details

Reviewers

Commits

R32:8a1b4f5fc361: kdevplatform: less auto-casting from/to ascii & from bytearray

Summary

kdevplatform/language/duchain/stringhelpers.cpp does not build though yet,
has some templates used both for qbytearray and qstring, which relies on
the otherwise hidden constructors

Diff Detail

Repository

R32 KDevelop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

kossebau created this revision.Oct 27 2017, 7:29 AM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 27 2017, 7:29 AM

LGTM (only had a relatively quick look)

kdevplatform/tests/CMakeLists.txt
1	Is this needed? Isn't it set by the parent CMakeLists.txt?

So as discussed on irc, will not discard this then, but see to turn this into something all maintainers agree on (and see how to get stringhelper.cpp solved)

Will prepare next some Best Practices Rules for qt string handling code (whether using QStringLiteral or QLatin1String in qstringbuilder-powered concatenations, how to avoid .data duplication when using same qstringliterals, etc) to put in some CODING,md file, so we have some golden rules around which should help to reduce the current random approaches. If good enough perhaps also could be moved to kde wikis for shared usage.

kdevplatform/tests/CMakeLists.txt
1	Good catch. Forgot to remove again, left-over from incrementally extending setting those defs.

kfunk accepted this revision.Oct 30 2017, 12:23 PM

This revision is now accepted and ready to land.Oct 30 2017, 12:23 PM

kossebau closed this revision.Oct 30 2017, 4:01 PM

kossebau marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			kdevplatform/CMakeLists.txt (6 lines)
M			kdevplatform/debugger/breakpoint/breakpoint.cpp (8 lines)
M			kdevplatform/debugger/breakpoint/breakpointmodel.cpp (2 lines)
M			kdevplatform/debugger/framestack/framestackmodel.cpp (2 lines)
M			kdevplatform/debugger/util/treeitem.cpp (4 lines)
M			kdevplatform/interfaces/iplugincontroller.h (2 lines)
M			kdevplatform/interfaces/isourceformatter.cpp (13 lines)
M			kdevplatform/language/assistant/renameassistant.cpp (2 lines)
M			kdevplatform/language/backgroundparser/documentchangetracker.cpp (4 lines)
M			kdevplatform/language/classmodel/classmodel.cpp (2 lines)
M			kdevplatform/language/classmodel/classmodelnode.cpp (4 lines)
M			kdevplatform/language/codecompletion/codecompletioncontext.cpp (2 lines)
M			kdevplatform/language/codecompletion/codecompletionhelper.cpp (14 lines)
M			kdevplatform/language/codecompletion/codecompletionworker.cpp (2 lines)
M			kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp (10 lines)
M			kdevplatform/language/codegen/applychangeswidget.cpp (2 lines)
M			kdevplatform/language/codegen/archivetemplateloader.cpp (2 lines)
M			kdevplatform/language/codegen/basicrefactoring.cpp (2 lines)
M			kdevplatform/language/codegen/coderepresentation.cpp (10 lines)
M			kdevplatform/language/codegen/documentchangeset.cpp (6 lines)
M			kdevplatform/language/codegen/templateclassgenerator.cpp (6 lines)
M			kdevplatform/language/codegen/templaterenderer.cpp (17 lines)
M			kdevplatform/language/codegen/templatesmodel.cpp (22 lines)
M			kdevplatform/language/duchain/classfunctiondeclaration.cpp (2 lines)
M			kdevplatform/language/duchain/declaration.cpp (2 lines)
M			kdevplatform/language/duchain/duchain.cpp (8 lines)
M			kdevplatform/language/duchain/dumpdotgraph.cpp (12 lines)
M			kdevplatform/language/duchain/identifier.cpp (12 lines)
M			kdevplatform/language/duchain/instantiationinformation.cpp (6 lines)
M			kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp (34 lines)
M			kdevplatform/language/duchain/navigation/abstractincludenavigationcontext.cpp (10 lines)
M			kdevplatform/language/duchain/navigation/abstractnavigationcontext.cpp (16 lines)
M			kdevplatform/language/duchain/navigation/abstractnavigationwidget.cpp (5 lines)
M			kdevplatform/language/duchain/navigation/problemnavigationcontext.cpp (4 lines)
M			kdevplatform/language/duchain/navigation/usescollector.cpp (6 lines)
M			kdevplatform/language/duchain/navigation/usesnavigationcontext.cpp (4 lines)
M			kdevplatform/language/duchain/navigation/useswidget.cpp (34 lines)
M			kdevplatform/language/duchain/stringhelpers.cpp (74 lines)
M			kdevplatform/language/duchain/topducontextdynamicdata.cpp (2 lines)
M			kdevplatform/language/duchain/types/functiontype.cpp (6 lines)
M			kdevplatform/language/duchain/types/integraltype.cpp (10 lines)
M			kdevplatform/language/duchain/types/unsuretype.cpp (2 lines)
M			kdevplatform/language/editor/modificationrevisionset.cpp (4 lines)
M			kdevplatform/language/interfaces/abbreviations.cpp (4 lines)
M			kdevplatform/language/interfaces/editorcontext.cpp (6 lines)
M			kdevplatform/language/interfaces/quickopendataprovider.cpp (2 lines)
M			kdevplatform/outputview/outputexecutejob.cpp (2 lines)
M			kdevplatform/outputview/tests/CMakeLists.txt (4 lines)
M			kdevplatform/project/CMakeLists.txt (3 lines)
M			kdevplatform/project/projectbuildsetmodel.cpp (2 lines)
M			kdevplatform/project/projectitemlineedit.cpp (6 lines)
M			kdevplatform/project/projectmodel.cpp (2 lines)
M			kdevplatform/project/tests/CMakeLists.txt (4 lines)
M			kdevplatform/project/widgets/dependencieswidget.cpp (2 lines)
M			kdevplatform/serialization/itemrepositoryregistry.cpp (8 lines)
M			kdevplatform/serialization/tests/CMakeLists.txt (6 lines)
M			kdevplatform/shell/documentcontroller.cpp (4 lines)
M			kdevplatform/shell/languagecontroller.cpp (6 lines)
M			kdevplatform/shell/openprojectdialog.cpp (12 lines)
M			kdevplatform/shell/partcontroller.cpp (2 lines)
M			kdevplatform/shell/plugincontroller.cpp (8 lines)
M			kdevplatform/shell/progresswidget/overlaywidget.cpp (2 lines)
M			kdevplatform/shell/progresswidget/progressdialog.cpp (2 lines)
M			kdevplatform/shell/projectcontroller.cpp (14 lines)
M			kdevplatform/shell/projectsourcepage.cpp (4 lines)
M			kdevplatform/shell/runcontroller.cpp (2 lines)
M			kdevplatform/shell/runtimecontroller.cpp (2 lines)
M			kdevplatform/shell/session.cpp (8 lines)
M			kdevplatform/shell/sessioncontroller.cpp (9 lines)
M			kdevplatform/shell/sessionlock.cpp (2 lines)
M			kdevplatform/shell/settings/pluginpreferences.cpp (22 lines)
M			kdevplatform/shell/settings/projectconfig.kcfg (2 lines)
M			kdevplatform/shell/settings/templatepage.cpp (2 lines)
M			kdevplatform/shell/sourceformattercontroller.cpp (16 lines)
M			kdevplatform/shell/sourceformatterjob.cpp (2 lines)
M			kdevplatform/shell/statusbar.cpp (3 lines)
M			kdevplatform/shell/textdocument.cpp (12 lines)
M			kdevplatform/shell/uicontroller.cpp (4 lines)
M			kdevplatform/shell/workingsetcontroller.cpp (2 lines)
M			kdevplatform/shell/workingsets/workingset.cpp (4 lines)
M			kdevplatform/shell/workingsets/workingsettooltipwidget.cpp (2 lines)
M			kdevplatform/sublime/aggregatemodel.cpp (2 lines)
M			kdevplatform/sublime/area.cpp (4 lines)
M			kdevplatform/sublime/areaindex.cpp (2 lines)
M			kdevplatform/sublime/container.cpp (6 lines)
M			kdevplatform/sublime/idealcontroller.cpp (2 lines)
M			kdevplatform/sublime/mainwindow.cpp (4 lines)
M			kdevplatform/sublime/tests/CMakeLists.txt (6 lines)
M			kdevplatform/sublime/urldocument.cpp (2 lines)
M			kdevplatform/template/filters/kdevfilters.cpp (12 lines)
M			kdevplatform/tests/CMakeLists.txt (3 lines)
M			kdevplatform/tests/json/delayedoutput.cpp (2 lines)
M			kdevplatform/tests/json/jsontesthelpers.h (2 lines)
M			kdevplatform/tests/testcore.cpp (2 lines)
M			kdevplatform/tests/testfile.cpp (6 lines)
M			kdevplatform/tests/testproject.cpp (4 lines)
M			kdevplatform/util/commandexecutor.cpp (4 lines)
M			kdevplatform/util/duchainify/main.cpp (2 lines)
M			kdevplatform/util/environmentprofilelist.cpp (6 lines)
M			kdevplatform/util/formattinghelpers.cpp (20 lines)
M			kdevplatform/util/kdevformatfile.cpp (20 lines)
M			kdevplatform/util/kdevformatsource.cpp (4 lines)
M			kdevplatform/util/kdevstringhandler.cpp (2 lines)
M			kdevplatform/util/path.cpp (16 lines)
M			kdevplatform/util/processlinemaker.cpp (4 lines)
M			kdevplatform/util/shellutils.cpp (4 lines)
M			kdevplatform/util/tests/CMakeLists.txt (4 lines)
M			kdevplatform/vcs/dvcs/dvcsjob.h (1 line)
M			kdevplatform/vcs/dvcs/dvcsjob.cpp (10 lines)
M			kdevplatform/vcs/models/tests/test_models.cpp (2 lines)
M			kdevplatform/vcs/models/vcsannotationmodel.cpp (2 lines)
M			kdevplatform/vcs/models/vcseventmodel.cpp (2 lines)
M			kdevplatform/vcs/widgets/vcsdiffpatchsources.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
e56f3a80b6ce	13935e26f45c	f2cd13e130b4	Friedrich W. H. Kossebau	kdevplatform: less auto-casting from/to ascii & from bytearray (Show More…)	Oct 26 2017, 8:00 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21414	f2cd13e		Oct 27 2017, 7:29 AM	★	★

kdevplatform: less auto-casting from/to ascii & from bytearrayClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 21414

kdevplatform/CMakeLists.txt

kdevplatform/debugger/breakpoint/breakpoint.cpp

kdevplatform/debugger/breakpoint/breakpointmodel.cpp

kdevplatform/debugger/framestack/framestackmodel.cpp

kdevplatform/debugger/util/treeitem.cpp

kdevplatform/interfaces/iplugincontroller.h

kdevplatform/interfaces/isourceformatter.cpp

kdevplatform/language/assistant/renameassistant.cpp

kdevplatform/language/backgroundparser/documentchangetracker.cpp

kdevplatform/language/classmodel/classmodel.cpp

kdevplatform/language/classmodel/classmodelnode.cpp

kdevplatform/language/codecompletion/codecompletioncontext.cpp

kdevplatform/language/codecompletion/codecompletionhelper.cpp

kdevplatform/language/codecompletion/codecompletionworker.cpp

kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp

kdevplatform/language/codegen/applychangeswidget.cpp

kdevplatform/language/codegen/archivetemplateloader.cpp

kdevplatform/language/codegen/basicrefactoring.cpp

kdevplatform/language/codegen/coderepresentation.cpp

kdevplatform/language/codegen/documentchangeset.cpp

kdevplatform/language/codegen/templateclassgenerator.cpp

kdevplatform/language/codegen/templaterenderer.cpp

kdevplatform/language/codegen/templatesmodel.cpp

kdevplatform/language/duchain/classfunctiondeclaration.cpp

kdevplatform/language/duchain/declaration.cpp

kdevplatform/language/duchain/duchain.cpp

kdevplatform/language/duchain/dumpdotgraph.cpp

kdevplatform/language/duchain/identifier.cpp

kdevplatform/language/duchain/instantiationinformation.cpp

kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp

kdevplatform/language/duchain/navigation/abstractincludenavigationcontext.cpp

kdevplatform/language/duchain/navigation/abstractnavigationcontext.cpp

kdevplatform/language/duchain/navigation/abstractnavigationwidget.cpp

kdevplatform/language/duchain/navigation/problemnavigationcontext.cpp

kdevplatform/language/duchain/navigation/usescollector.cpp

kdevplatform/language/duchain/navigation/usesnavigationcontext.cpp

kdevplatform/language/duchain/navigation/useswidget.cpp

kdevplatform/language/duchain/stringhelpers.cpp

kdevplatform/language/duchain/topducontextdynamicdata.cpp

kdevplatform/language/duchain/types/functiontype.cpp

kdevplatform/language/duchain/types/integraltype.cpp

kdevplatform/language/duchain/types/unsuretype.cpp

kdevplatform/language/editor/modificationrevisionset.cpp

kdevplatform/language/interfaces/abbreviations.cpp

kdevplatform/language/interfaces/editorcontext.cpp

kdevplatform/language/interfaces/quickopendataprovider.cpp

kdevplatform/outputview/outputexecutejob.cpp

kdevplatform/outputview/tests/CMakeLists.txt

kdevplatform/project/CMakeLists.txt

kdevplatform/project/projectbuildsetmodel.cpp

kdevplatform/project/projectitemlineedit.cpp

kdevplatform/project/projectmodel.cpp

kdevplatform/project/tests/CMakeLists.txt

kdevplatform/project/widgets/dependencieswidget.cpp

kdevplatform/serialization/itemrepositoryregistry.cpp

kdevplatform/serialization/tests/CMakeLists.txt

kdevplatform/shell/documentcontroller.cpp

kdevplatform/shell/languagecontroller.cpp

kdevplatform/shell/openprojectdialog.cpp

kdevplatform/shell/partcontroller.cpp

kdevplatform/shell/plugincontroller.cpp

kdevplatform/shell/progresswidget/overlaywidget.cpp

kdevplatform/shell/progresswidget/progressdialog.cpp

kdevplatform/shell/projectcontroller.cpp

kdevplatform/shell/projectsourcepage.cpp

kdevplatform/shell/runcontroller.cpp

kdevplatform/shell/runtimecontroller.cpp

kdevplatform/shell/session.cpp

kdevplatform/shell/sessioncontroller.cpp

kdevplatform/shell/sessionlock.cpp

kdevplatform/shell/settings/pluginpreferences.cpp

kdevplatform/shell/settings/projectconfig.kcfg

kdevplatform/shell/settings/templatepage.cpp

kdevplatform/shell/sourceformattercontroller.cpp

kdevplatform/shell/sourceformatterjob.cpp

kdevplatform: less auto-casting from/to ascii & from bytearray
ClosedPublic
Actions

Revision Contents
Changeset List