Modernize code. Use nullptr where it's possible
ClosedPublic
Actions

Authored by mlaurent on Oct 25 2017, 1:41 PM.

Details

Reviewers

Commits

Summary

Remove extra ';'
Use override everywhere as we already use it in some part of code
Fix potential crash when we delete a pointer

Test Plan

build/using :)

Repository

R119 Plasma Desktop

Branch

modernize_folderplugin

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik added inline comments.

containments/desktop/plugins/folder/mimetypesmodel.cpp
109 ↗	(On Diff #21309)	Isn't the compiler smart ehough?
containments/desktop/plugins/folder/previewpluginsmodel.cpp
112 ↗	(On Diff #21309)	Space after `=`

containments/desktop/plugins/folder/mimetypesmodel.cpp
109 ↗	(On Diff #21309)	Really I don't know if compiler is able to resolve it when it's not a const variable. If you told me that gcc/clang is able to do it ok :) I can trust you if you told me it's not a problem

This revision is now accepted and ready to land.Oct 26 2017, 8:49 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			containments/desktop/plugins/folder/directorypicker.cpp (2 lines)
M			containments/desktop/plugins/folder/foldermodel.h (8 lines)
M			containments/desktop/plugins/folder/foldermodel.cpp (25 lines)
M			containments/desktop/plugins/folder/labelgenerator.cpp (6 lines)
M			containments/desktop/plugins/folder/mimetypesmodel.h (6 lines)
M			containments/desktop/plugins/folder/mimetypesmodel.cpp (2 lines)
M			containments/desktop/plugins/folder/placesmodel.h (2 lines)
M			containments/desktop/plugins/folder/positioner.h (10 lines)
M			containments/desktop/plugins/folder/positioner.cpp (2 lines)
M			containments/desktop/plugins/folder/previewpluginsmodel.h (6 lines)
M			containments/desktop/plugins/folder/previewpluginsmodel.cpp (2 lines)
M			containments/desktop/plugins/folder/rubberband.h (4 lines)
M			containments/desktop/plugins/folder/shortcut.h (2 lines)
M			containments/desktop/plugins/folder/viewpropertiesmenu.h (4 lines)
M			containments/desktop/plugins/folder/viewpropertiesmenu.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21309	3c30283		Oct 25 2017, 1:41 PM	★	★
Diff 2	21348	3c30283	- Perhaps gcc/clang can optimize it.	Oct 26 2017, 7:42 AM	★	★
Diff 3	21356	9d0b117	R119:b95bdf216b8fa1ed12a3363522583d16a5c4de28	Oct 26 2017, 9:20 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
35247da6ecf8	3ae501e794a7	6201613e2a79	Montel Laurent	Perhaps gcc/clang can optimize it.	Oct 26 2017, 7:42 AM
6201613e2a79	499f1e1d3309	3c30283a3ad6	Montel Laurent	Modernize code. Use nullptr where it's possible (Show More…)	Oct 25 2017, 1:40 PM