Do not emit statechanged when state has not changed
ClosedPublic

Authored by wcancino on Oct 24 2017, 1:36 PM.

Details

Summary

BUG: 385889

This correct the loop in Xdebug plugin

Diff Detail

Repository
R68 KDevelop XDebug Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wcancino created this revision.Oct 24 2017, 1:36 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 24 2017, 1:36 PM
ngraham added a subscriber: ngraham.EditedOct 24 2017, 2:30 PM

Please change the title to just be "Do not emit statechanged when state has not changed"

And add "BUG: [bug number]" on its own line in the Summary. Thanks!

Also, are you sure 158264 is the right bug? That points to a recent Dolphin fix.

wcancino retitled this revision from Fix for kde bug: 158264 -- do not emit statechanged when state has not changed to Do not emit statechanged when state has not changed.Oct 24 2017, 2:36 PM
wcancino edited the summary of this revision. (Show Details)

Fixed!

"Fix Bug #385889" isn't good enough I'm afraid. It needs to be exactly "BUG: 385889". That's a special keyword.

wcancino edited the summary of this revision. (Show Details)Oct 24 2017, 2:40 PM
wcancino edited the summary of this revision. (Show Details)
apol accepted this revision.Oct 24 2017, 2:42 PM
apol added a subscriber: apol.

Do you need us to do the push for you?

This revision is now accepted and ready to land.Oct 24 2017, 2:42 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Oct 24 2017, 4:27 PM

Thanks a lot for the patch!