Differential D8445

[PlasmaComponents Menu] Add ungrabMouseHack
ClosedPublic
Actions

Authored by broulik on Oct 24 2017, 12:42 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack
Summary

Ensures the PlasmaComponents.Menu doesn't confuse MouseArea states.

Test Plan

Put a ContextMenu into NotificationPopup, opened it, selected an item, and the MouseArea knew it wasn't pressed anymore. Before it got confused.
Also played around in Kickoff and Task Manager and didn't notice anything suspicious

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 24 2017, 12:42 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptOct 24 2017, 12:42 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 24 2017, 1:58 PM
davidedmundson added a subscriber: davidedmundson.

I was under the impression this hack was only needed when used on a window that doesn't take focus.
(https://bugreports.qt.io/browse/QTBUG-59044?focusedCommentId=354424&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-354424)

The popup should, so it doesn't match my findings in the qtbug you're linking to.

This revision is now accepted and ready to land.Oct 24 2017, 1:58 PM
Closed by commit R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack (authored by broulik). · Explain WhyOct 25 2017, 1:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21305

View Options

src/declarativeimports/plasmacomponents/qmenu.h

Loading...
View Options

src/declarativeimports/plasmacomponents/qmenu.cpp

Loading...