Differential D8414

libzip: Add support for compression methods and levels
ClosedPublic
Actions

Authored by rthomsen on Oct 22 2017, 8:11 AM.

Details

Reviewers
elvisangelaccio
Commits
R36:ee5d045b058a: libzip: Add support for compression methods and levels
Summary

Add support for bzip2 compression method and compression levels. These features were added in libzip 1.3.0.

Test Plan

Create zip archives with libzip plugin and select different comp.methods and levels.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen created this revision.Oct 22 2017, 8:11 AM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald TranscriptOct 22 2017, 8:11 AM
elvisangelaccio accepted this revision.Oct 22 2017, 9:20 AM
elvisangelaccio added inline comments.
plugins/libzipplugin/libzipplugin.cpp
275

Can be simplified in:

const int compLevel = options.isCompressionLevelSet() ? options.compressionLevel() : 6;

This revision is now accepted and ready to land.Oct 22 2017, 9:20 AM
rthomsen updated this revision to Diff 21121.Oct 22 2017, 11:29 AM

Follow Elvis' suggestion.

rthomsen marked an inline comment as done.Oct 22 2017, 11:29 AM
Closed by commit R36:ee5d045b058a: libzip: Add support for compression methods and levels (authored by rthomsen). · Explain WhyOct 22 2017, 11:32 AM
This revision was automatically updated to reflect the committed changes.
rthomsen mentioned this in R36:ee5d045b058a: libzip: Add support for compression methods and levels.

Revision Contents
Changeset List

Diff 21124

View Options

CMakeLists.txt

Loading...
View Options

plugins/libzipplugin/kerfuffle_libzip.json.cmake

Loading...
View Options

plugins/libzipplugin/libzipplugin.cpp

Loading...