kmymoney fails to build without qtwebkit - therefore add it as a build dependency in the blueprint file.
Details
Details
- Reviewers
vonreth - Group Reviewers
Craft - Commits
- R877:d1afda15a85b: add qtwebkit dependency to kmymoney blueprint
Diff Detail
Diff Detail
- Repository
- R138 Craft
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| extragear/kmymoney/kmymoney.py | ||
|---|---|---|
| 35 | Should be runtimeDependencies, no? | |
Comment Actions
Changed to runtime dependency as requested.
This might seem like a stupid question, but since I ran into the same issue before (and guessed wrong again): Could you explain how to tell from the build output what should be considered a build dependency vs. a runtime dependency? To me, "build dependency" implied "build will fail if not present" (which is what happened and is the reason I added it) but I seem to be missing something here...
Comment Actions
Build time dependencies are tools that are only needed during build time, like a compiler etc.
Runtime deps are always needed so when we create a installer or something similar we need to ship them, on the other hand it wouldn't make sense to package the buildtime deps :) .
Comment Actions
That makes sense, thanks for clarifying.
Would you mind taking care of merging the patch (I don't have write access to the repo)?
Thanks!
Comment Actions
Applied in https://commits.kde.org/craft-blueprints-kde/d1afda15a85ba44a4790e3463dfcfaa00870a1d6
For some reason arcanist replaces the author of the change...
Comment Actions
I think the patch had no author information, was probably uploaded via the web ui. You can see that based on the "Context not available." in the diff view.