@rempt What's your opinion on the part downloading gmic source files? The make targets cannot be run on Windows directly so I have CMake do it instead.

Regarding OS X, perhaps you could ask poke1024 for a bit of help over at T5675?

alvinhochun updated this revision to Diff 21042.Oct 21 2017, 10:00 AM

Yes, letting cmake download those files is the right approach.

This revision is now accepted and ready to land.Oct 23 2017, 10:31 AM

Closed by commit R37:b1a458c9e54c: Add gmic-qt to 3rdparty/ as ext_gmic (authored by alvinhochun). · Explain WhyOct 23 2017, 2:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		3rdparty/CMakeLists.txt (4 lines)
M		3rdparty/README.md (4 lines)
A	M	3rdparty/ext_gmic/CMakeLists.txt (45 lines)
A	M	3rdparty/ext_gmic/gmic-downloads.cmake (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21041			Oct 21 2017, 9:46 AM	★	★
Diff 2	21042			Oct 21 2017, 9:59 AM	★	★
Diff 3	21182	c998e13	R37:b1a458c9e54c1c2fe02afa7b45b1058964668c27	Oct 23 2017, 2:36 PM	★	★