Always force recursive list jobs.
ClosedPublic

Authored by mwolff on Jan 19 2016, 10:54 AM.

Details

Summary

The CMakeManager uses createImportJob on reload which was previously
stopping on known folders. This lead to various issues, esp. when
switching branches we sometimes missed new contents in folders etc.

I don't remember anymore why this whole logic existed before,
potentially some not-so-smart performance optimization which breaks
things. Since I didn't add good comments back then, lets remove it
for now and see how it works. If things become slow we can always
optimize later on.

Test Plan

Generic manager test works, as does using it for real.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff updated this revision to Diff 2014.Jan 19 2016, 10:54 AM
mwolff retitled this revision from to Always force recursive list jobs..
mwolff updated this object.
mwolff edited the test plan for this revision. (Show Details)
mwolff added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 19 2016, 10:54 AM
apol accepted this revision.Jan 19 2016, 11:11 AM
apol added a reviewer: apol.
apol added a subscriber: apol.

+1

especially removing a "force" argument bit. :)

This revision is now accepted and ready to land.Jan 19 2016, 11:11 AM
This revision was automatically updated to reflect the committed changes.