Differential D8357

[IntroIcon] Use Kirigami.Label instead of QQC2.Label
AbandonedPublic
Actions

Authored by broulik on Oct 18 2017, 1:15 PM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Summary

Fixes the label not picking up color scheme properly.

Test Plan

The icons in the Frequently Used list have readable text with dark colorschemes now.

Diff Detail

Repository
R124 System Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 18 2017, 1:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2017, 1:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Oct 18 2017, 1:17 PM

I just updated my Kirigami to master and now the kirigami label is also dark erroneously o.O

broulik added a comment.Oct 18 2017, 1:27 PM

Urgh, even says Kirigami.Label is deprecated. Meeh. So something is severly broken somewhere :(

davidedmundson requested changes to this revision.Oct 18 2017, 6:11 PM
davidedmundson added a subscriber: davidedmundson.

Change doesn't make sense.

If there's a bug in the QQC2 dekstop style label, then there's a bug in QQC2 dekstop style label.
Avoiding the problem doens't fix it.

This revision now requires changes to proceed.Oct 18 2017, 6:11 PM
davidedmundson added a comment.Oct 18 2017, 6:28 PM

The icons in the Frequently Used list have readable text with dark colorschemes now.

What's the issue with dark themes. I have one. It seems fine.
Do you mean runtime switching?

broulik abandoned this revision.Oct 18 2017, 6:28 PM
davidedmundson added a comment.Oct 18 2017, 8:16 PM

Following this up.

QQC2.Label gets colours from "PlasmaDesktopTheme.cpp"

This does calling setTextColor when the palette changes.
However always with the same value, as though the KColorScheme hasn't been updated yet

Revision Contents
Changeset List

Diff 20943

View Options

sidebar/package/contents/ui/IntroIcon.qml

Loading...