Remove check for SNI hosts when chosing
ClosedPublic

Authored by davidedmundson on Oct 18 2017, 10:04 AM.

Details

Summary

Previous code (since very first commit) checked for both having a valid
KSNI watcher as well as making sure there was a host available in order
to choose which mode to use.

This made some sense when Plasma 4 still had proper xembed support and
one could turn SNIs off.

The current code here is broken. On first creation we only check for a
watcher - and only ends up checking for the host if it changes at
runtime.

Given it's not working properly, and the use case has changed it seems
we can safely remove this code.

This removes a blocking DBus call on the property.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 18 2017, 10:04 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
graesslin accepted this revision.Oct 18 2017, 3:27 PM
graesslin added a subscriber: graesslin.

Just tested: this fixes the freeze I'm experiencing on startup!

This revision is now accepted and ready to land.Oct 18 2017, 3:27 PM

Just tested: this fixes the freeze I'm experiencing on startup!

It's a combo of both this, the other one, and apparently your change from a while ago with the async version lookup. I'm quite glad there isn't a forth issue!

I suggest us devs export Q_DBUS_BLOCKING_CALL_OTHER_THREAD_WARNING_MS to 0
it will let you know quicker if kwin/plasma ever makes a blocking call and where.

This revision was automatically updated to reflect the committed changes.