Implement different modes for sensor curves
ClosedPublic
Actions

Authored by radianart on Oct 17 2017, 11:05 AM.

Details

Reviewers

rempt
woltherav
scottpetrovic

Summary

Right now values from all curves multiply, this diff add new modes: add, max, min, difference.

Add, max and min are self explanatory, I guess.
Diff is some sort of XOR, bigger difference between values - bigger result.

I also added some brushes with different modes to play with.

I need feedback about actual code in kis_curve_option.cpp plus feedback about tool tip and how combobox looks.

knife3.gbr87 KBDownload

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

radianart created this revision.Oct 17 2017, 11:05 AM

rempt added inline comments.Oct 17 2017, 11:46 AM

plugins/paintops/libpaintop/kis_curve_option.cpp
371	I would suggest using enums here, insted of integers.

In terms of the UI, I think it would be nice to describe a bit better what is going on without a having to read a long tooltip. I don't think this is a common option, so we probably need to spell it out better without a hover event.

This is what I am thinking

Add a label for the combobox to the left. Maybe something like "Curve Compositing".
Be slightly more descriptive on the options. Instead of "mul", say "Multiply all values".

Updated ui to make feature more noticeable.

@radianart -- ahh nice

Little change to make code more logical.

I'm fine with pushing this, but please push me to change the integers to an enum for you when done :-)

This revision is now accepted and ready to land.Nov 2 2017, 8:24 AM

Pushed

Revision Contents
Changeset List

			Path	Packages
M			plugins/paintops/libpaintop/forms/wdgcurveoption.ui (295 lines)
M			plugins/paintops/libpaintop/kis_curve_option.h (5 lines)
M			plugins/paintops/libpaintop/kis_curve_option.cpp (46 lines)
M			plugins/paintops/libpaintop/kis_curve_option_widget.h (3 lines)
M			plugins/paintops/libpaintop/kis_curve_option_widget.cpp (8 lines)