Differential D8321

Only check for legacy system tray icons if we're going to make one
ClosedPublic
Actions

Authored by davidedmundson on Oct 15 2017, 9:43 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R289:800908eaec7a: Only check for legacy system tray icons if we're going to make one
Summary

On Plasma is a rather pointless check as our QPT uses SNIs
so we end up checking something we've already checked,
only in a blocking way - and we're going to no-op anyway.

BUG: 385371

Test Plan

killed kded5
created an SNI. It failed into the else branch

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 15 2017, 9:43 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptOct 15 2017, 9:43 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
graesslin accepted this revision.Oct 16 2017, 4:21 AM
This revision is now accepted and ready to land.Oct 16 2017, 4:21 AM
Closed by commit R289:800908eaec7a: Only check for legacy system tray icons if we're going to make one (authored by davidedmundson). · Explain WhyOct 17 2017, 7:08 AM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a comment.Oct 17 2017, 4:05 PM

Trace is different, so ...progress!

I don't think there's anything specifically wrong with this patch in itself.

I'll fix that and review the rest of this class.
Sorry, Thanks for the quick feedback.

Revision Contents
Changeset List

PathPackages
Msrc/kstatusnotifieritem.cpp (7 lines)

Diff 20889

View Options

src/kstatusnotifieritem.cpp

Loading...