Differential D8311

Require the same internal version as you're building
ClosedPublic
Actions

Authored by leinir on Oct 15 2017, 2:01 PM.

Details

Reviewers
dfaure
Group Reviewers
KNewStuff
Commits
R304:e33d06f9857a: Require the same internal version as you're building
Summary

Previously the KNewStuff sub-frameworks would require the dependency frameworks version of itself, rather than the version being built, which caused fun little issues.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Oct 15 2017, 2:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 15 2017, 2:01 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Dec 2 2017, 5:15 PM
dfaure added a subscriber: dfaure.

Fun indeed.

Hmm I see the same issue in at least kdelibs4support, I'll go fix it.

Anyone wants to write a small script to check this? ;)

This revision is now accepted and ready to land.Dec 2 2017, 5:15 PM
Closed by commit R304:e33d06f9857a: Require the same internal version as you're building (authored by leinir). · Explain WhyDec 18 2017, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24076

View Options

KF5NewStuffConfig.cmake.in

Loading...
View Options

KF5NewStuffQuickConfig.cmake.in

Loading...