Differential D8286

Port away from PlasmaCore.Units in system settings modules
ClosedPublic
Actions

Authored by davidedmundson on Oct 14 2017, 6:23 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:06e2cf0d9771: Port away from PlasmaCore.Units in system settings modules
Summary

As Kirigrami has it's own version.

We want to be moving towards not having any Plasma imports in KCM code.
(except for theme previews)

Test Plan

Opened all 3 KCMs listed
They looked pretty much identical

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 14 2017, 6:23 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 14 2017, 6:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Oct 14 2017, 9:11 AM
apol added inline comments.
kcms/ksplash/package/contents/ui/main.qml
27–28

Should be using Units.gridUnit, no?

mart added a subscriber: mart.Oct 15 2017, 4:31 PM
mart added inline comments.
kcms/ksplash/package/contents/ui/main.qml
27–28

this needs porting too, then good to go

davidedmundson updated this revision to Diff 20891.Oct 17 2017, 8:20 AM

Change units to Units

mart accepted this revision.Oct 17 2017, 8:20 AM
This revision is now accepted and ready to land.Oct 17 2017, 8:20 AM
Closed by commit R119:06e2cf0d9771: Port away from PlasmaCore.Units in system settings modules (authored by davidedmundson). · Explain WhyOct 17 2017, 8:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20894

View Options

kcms/desktoptheme/package/contents/ui/main.qml

Loading...
View Options

kcms/ksplash/package/contents/ui/main.qml

Loading...
View Options

kcms/lookandfeel/package/contents/ui/main.qml

Loading...