Don't duplicate connect to wl_display_flush
ClosedPublic
Actions

Authored by davidedmundson on Oct 14 2017, 5:14 AM.

Details

Reviewers

Commits

Summary

When using the QPA's wl_display, we don't need to also flush when the
event dispatcher blocks, as Qt's QPA already does this.

This also fixes a warning on startup about a null parameter when our QPT
creates a connectionThread before the eventDispatcher is created.

Test Plan

Confirmed the Qt wayland QPA has the same connect to the event dispatcher

Ran app:
No more warning
Still had correct window decorations

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

I don't see in the change what you describe. This seems to be just a refactoring.

The other ctor has a connect in the body.

Ahhh. That's of course tricky to spot in this change ;-)

This revision is now accepted and ready to land.Oct 14 2017, 12:47 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/client/connection_thread.h (6 lines)
M			src/client/connection_thread.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20708	b9705b6		Oct 14 2017, 5:14 AM	★	★
Diff 2	20744	b9705b6	R127:f48b796c74d5b574e3a60770d68ceabcbc873f95	Oct 14 2017, 5:14 AM	★	★