At the moment we are compiling the tool against android then trying to
execute it, which obviously doesn't work. Building locally would require
having native Qt available and further changes in the code.
Details
Details
- Reviewers
kfunk - Group Reviewers
Frameworks Plasma - Commits
- R266:c0c4e4f46ae1: Fix build of breeze-icons on the Android CI
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| CMakeLists.txt | ||
|---|---|---|
| 23 | Better: GENERATE_ICONS_DEFAULT -> BINARY_ICONS_RESOURCE_OPTION_DEFAULT (consistent naming) Also add some comment why it's disabled when cross-compiling. | |
Comment Actions
That comment could be a bit more verbose and better placed (i.e. move it next to set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF) and make it something along "When cross-compiling qrcAlias would be compiled against Embedded Qt, thus disable ... -- TODO: should compile ..."
But okay :)