Make calendar pin persistent across sessions
ClosedPublic

Authored by davidedmundson on Oct 11 2017, 6:06 PM.

Details

Summary

A user can "pin" the calendar so that it won't get closed on focus
change, but only when the clock is clicked again.

This persists across open/close operations, but currently doesn't
persist across Plasma restarts.

This patch loads the saved config value of the last pinned state.

Test Plan

Opened calendar, set pin, closed it, reopened and it was still pinned (which is the current state)
killed plasma, restarted plasma, was still pinned (new)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 11 2017, 6:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 11 2017, 6:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Should we do the same for System Tray? I don't think anybody would do this but it should be consistent

applets/digital-clock/package/contents/config/main.xml
69

Whether to keep the calendar popup opened when it loses focus

I agree on the consistent part.

davidedmundson planned changes to this revision.Oct 12 2017, 11:37 AM

Include systray

broulik added inline comments.Oct 12 2017, 1:20 PM
applets/digital-clock/package/contents/config/main.xml
69

You got it the wrong way round now, it implies that true means it should close

broulik accepted this revision.Oct 12 2017, 1:52 PM
This revision is now accepted and ready to land.Oct 12 2017, 1:52 PM
This revision was automatically updated to reflect the committed changes.