Differential D8200

Fix T6906
ClosedPublic
Actions

Authored by rizzitello on Oct 8 2017, 1:57 PM.

Tags

Subscribers

patrickelectric, tcanabrava, Atelier: AtCore

Details

Reviewers

laysrodrigues
tcanabrava
patrickelectric

Group Reviewers

Atelier: AtCore

Maniphest Tasks

T6906: Fix Temperature Misread in APrinter

Commits

R232:229c2d0c21ab: Fix T6906
R232:c801b47608cf: Adjust logic to fix reading of temperatures when bed temp is sent before…

Summary

Fix T6906 by checking if extruder or bed temperature is sent first then adjusting
temperature storage accordingly

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rizzitello created this revision.Oct 8 2017, 1:57 PM

rizzitello added a reviewer: Atelier: AtCore.Oct 8 2017, 1:58 PM

rizzitello added a project: Atelier: AtCore.

rizzitello mentioned this in T6906: Fix Temperature Misread in APrinter.

rizzitello added a subscriber: Atelier: AtCore.

laysrodrigues accepted this revision.Oct 8 2017, 2:09 PM

This revision is now accepted and ready to land.Oct 8 2017, 2:09 PM

just remember to add a TODO: Clear this later.

Redo the fix

way way better.

patrickelectric requested changes to this revision.Oct 10 2017, 2:41 PM

patrickelectric added a subscriber: patrickelectric.

patrickelectric added inline comments.

src/temperature.cpp
99	Use a better variable name, like: targetBed and targetExt.

This revision now requires changes to proceed.Oct 10 2017, 2:41 PM

rizzitello added inline comments.Oct 10 2017, 3:31 PM

src/temperature.cpp
99	At this point we do not know if temp1 or temp2 is the bed or extruder target.For this reason I just left them as temp1 and temp2.

Better varible names

rizzitello marked an inline comment as done.Oct 13 2017, 3:33 PM

patrickelectric accepted this revision.Oct 13 2017, 4:38 PM

patrickelectric added inline comments.

src/temperature.cpp
99	Ty for the new name.

This revision is now accepted and ready to land.Oct 13 2017, 4:38 PM

Closed by commit R232:c801b47608cf: Adjust logic to fix reading of temperatures when bed temp is sent before… (authored by rizzitello). · Explain WhyOct 13 2017, 4:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/temperature.cpp (22 lines)

Diff 20686

src/temperature.cpp

Loading...