Improve setting global lock shortcut
ClosedPublic

Authored by graesslin on Jan 14 2016, 2:43 PM.

Details

Summary

KSld is a library which means the componentName is set to the application
name. This works fine for KSMServer, but in KWin the shortcut didn't
work.

This change manually sets the proper component name (ksmserver) on the
QAction and at the same time removes the usage of the KActionCollection.

Due to that we can also drop the dependency on XmlGui.

Test Plan

Locking screen through configured shortcut works now in kwin_wayland.

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 1960.Jan 14 2016, 2:43 PM
graesslin retitled this revision from to Improve setting global lock shortcut.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: bshah.
graesslin added a subscriber: plasma-devel.
graesslin added a project: Plasma.
bshah accepted this revision.Jan 15 2016, 3:35 AM
bshah edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 3:35 AM
bshah added a comment.Jan 15 2016, 3:36 AM

On second thought, Actually maybe, we rename component to (k)screenlocker and provide migration scripts?

In D820#15811, @bshah wrote:

On second thought, Actually maybe, we rename component to (k)screenlocker and provide migration scripts?

Yes I want to do that, but as a second step. Migrating global shortcuts is always messy, so this is a little bit more work.

On third thought: maybe we need to create a "Plasma Workspace" component where we group currently scattered shortcuts like lock screen, log out, etc.

This revision was automatically updated to reflect the committed changes.