Details
- Reviewers
knauss - Commits
- R81:b50a08170d4b: Port the WKS formatter to the new rendering API
Diff Detail
- Repository
- R81 KDE PIM Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
plugins/messageviewer/bodypartformatter/autotests/data/wks-confirmation-request-multipart-decrypted.mbox.html | ||
---|---|---|
29 | right-to-left support? | |
plugins/messageviewer/bodypartformatter/gnupgwks/gnupgwksformatter.cpp | ||
94 | should be start and handled via memento to not block kmail. but this is another issue. | |
plugins/messageviewer/bodypartformatter/gnupgwks/plugin.cpp | ||
30–31 | why resort the Index? |
plugins/messageviewer/bodypartformatter/gnupgwks/plugin.cpp | ||
---|---|---|
31 | Because the emails sent by the WKD server are actually multipart/mixed emails with special parts - we inspect those parts in this plugin and if one of the parts contains application/vnd.gnupg.keys we handle the entire email specially in this plugin and otherwise we pass them back to the regular multipart/mixed handler. |
plugins/messageviewer/bodypartformatter/autotests/data/wks-confirmation-request-multipart-decrypted.mbox.html | ||
---|---|---|
29 | possible, but this was broken before already then, the output wasn't changed by this patch | |
plugins/messageviewer/bodypartformatter/gnupgwks/gnupgwksformatter.cpp | ||
94 | very valid concern, but also not introduced by this patch | |
plugins/messageviewer/bodypartformatter/gnupgwks/plugin.cpp | ||
30–31 | because we have a processing plugin for all three, but only a renderer for the first two |
plugins/messageviewer/bodypartformatter/autotests/data/wks-confirmation-request-multipart-decrypted.mbox.html | ||
---|---|---|
29 | sure, but let's address this separately then, not as part of an unrelated patch | |
plugins/messageviewer/bodypartformatter/gnupgwks/gnupgwksformatter.cpp | ||
94 | dito | |
plugins/messageviewer/bodypartformatter/gnupgwks/plugin.cpp | ||
30–31 | that's in the json file, the renderer section only has two entries, so those need to be on 0 and 1 in this enum |