Differential D8171

Port TNEF plugin to new rendering plugin API
ClosedPublic
Actions

Authored by vkrause on Oct 7 2017, 10:17 AM.

Details

Reviewers
knauss
Commits
R81:35d1d8615ad0: Port TNEF plugin to new rendering plugin API
Summary

By using the standard inline attachment container we also get the proper
attachment links now.

Diff Detail

Repository
R81 KDE PIM Addons
Branch
top
Lint
No Linters Available
Unit
No Unit Test Coverage
vkrause created this revision.Oct 7 2017, 10:17 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 7 2017, 10:17 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added inline comments.Oct 9 2017, 8:43 AM
plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html
22

we need the dir setting to support right-to-left languages

vkrause added inline comments.Oct 9 2017, 7:19 PM
plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html
22

this is broken in the generic attachment container already then, no?

knauss added inline comments.Oct 10 2017, 8:46 AM
plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html
22

looks like this. But I never tested right-to-left language, so i don't know.

knauss accepted this revision.Oct 10 2017, 10:18 PM

needs testing with r-t-l language, but anyways that it not part of this patch

This revision is now accepted and ready to land.Oct 10 2017, 10:18 PM
Closed by commit R81:35d1d8615ad0: Port TNEF plugin to new rendering plugin API (authored by vkrause). · Explain WhyOct 15 2017, 9:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20426

View Options

plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/tnef-two-files.mbox.html

Loading...
View Options

plugins/messageviewer/bodypartformatter/ms-tnef/CMakeLists.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/ms-tnef/application_ms-tnef.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/ms-tnef/application_ms-tnef.json

Loading...