Add DBus protocol to virtual keyboard
ClosedPublic

Authored by graesslin on Oct 7 2017, 5:39 AM.

Details

Summary

This change adds a DBus API to query whether the virtual keyboard is
currently enabled and provides DBus methods to request that the virtual
keyboard gets enabled/disabled. This is useful for e.g. providing a
Plasmoid or for convertables where the tablet mode needs to be enabled.

Diff Detail

Repository
R108 KWin
Branch
virt-keyboard-dbus
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Oct 7 2017, 5:39 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 7 2017, 5:39 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
  • you may as well wait to see if I do actually fix Knotifications, if not merge the other one

(give me till next frameworks as a deadline)

  • Next time you end up with a situation where you have an object and you want to expose some of that metaobject to a DBus interface, use QDBusAbstractAdaptors as a pattern.

It's less code, even less if autogenerated, and you don't open up yourself to cases where enabled can get out of sync.

Not worth changing now you've written it.

davidedmundson accepted this revision.Oct 17 2017, 7:09 AM
This revision is now accepted and ready to land.Oct 17 2017, 7:09 AM

I'm sorry, but the deadlock is not fixed. I just compiled the latest knotifications, logged out and in and still had the freeze.

This revision was automatically updated to reflect the committed changes.