I don't know how to set it up for testing...
Details
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
I think it's good to show the dialog if there's just the one device. This way you see what's happening, at least that was my thinking.
I did it because I used KDEConnect to open tel:+390123456 links on the web to dial these numbers and that window appeared to be quite bothering...
The creator of a review is an implicit subscriber from my understanding of how Phabricator works here.
@bcooksley when I visit email settings page https://phabricator.kde.org/settings/user/zhigalin/page/email/ I see only this error:
Unhandled Exception ("InvalidArgumentException")
Argument 1 passed to PHUIHeaderView::addActionLink() must be an instance of PHUIButtonView, null given, called in /srv/phabricator/phabricator/src/applications/settings/panel/PhabricatorSettingsPanel.php on line 290 and defined
I've taken an initial look at that and can confirm the issue, although not why it is occurring and have reached out to the Phabricator developers.
@bcooksley Any news?
I didn't noticed that because I was on the KDevelop mailing list and I was receiving replies from it but it seems that I have never received any mail from phabricator...
The Phabricator developers have fixed it, and the fix will be included in our next rollout.