Differential D807

Fix for Bug 357684
Needs RevisionPublic
Actions

Authored by danielsabo on Jan 13 2016, 6:58 PM.

Details

Reviewers
davidedmundson
aacid
graesslin
Group Reviewers
Plasma
Summary

The existing code in KDEPlatformFileDialogHelper::initializeDialog() only calls setConfirmOverwrite() to set it to false, this is a noop because the KDE dialog defaults to no confirmation.

This patch changes the behavior to always set setConfirmOverwrite() to match the DontConfirmOverwrite flag, which will produce the correct behavior no matter what the default behavior of the KDE dialog is.

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Lint Skipped
Unit
Unit Tests Skipped
danielsabo updated this revision to Diff 1933.Jan 13 2016, 6:58 PM
danielsabo retitled this revision from to Fix for Bug 357684.
danielsabo updated this object.
danielsabo edited the test plan for this revision. (Show Details)
danielsabo added a reviewer: Plasma.
danielsabo set the repository for this revision to R135 Integration for Qt applications in Plasma.
danielsabo added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJan 13 2016, 6:58 PM
davidedmundson accepted this revision.Jan 14 2016, 12:00 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 14 2016, 12:00 AM
graesslin accepted this revision.Jan 14 2016, 6:57 AM
graesslin added a reviewer: graesslin.
graesslin added a subscriber: graesslin.
graesslin added inline comments.
src/platformtheme/kdeplatformfiledialoghelper.cpp
275

small nitpick: you could const the bool confirmOverwrite

danielsabo updated this revision to Diff 1971.Jan 14 2016, 11:22 PM
danielsabo edited edge metadata.

const'd bool

aacid requested changes to this revision.Feb 26 2017, 10:36 PM
aacid added a subscriber: aacid.

As far as i can see this was never commited and now does not apply anymore.

Can you please update it?

This revision now requires changes to proceed.Feb 26 2017, 10:36 PM

Revision Contents
Changeset List

Diff 1971

View Options

src/platformtheme/kdeplatformfiledialoghelper.cpp

Loading...