Interface::MessagePart is neither pure-virtual nor is it ever instantiated
now that legacy handling has been separated out, which removes its reason
to exist. This allows simplifying its usage, as we no longer need to
deal with the distinction.
Details
Details
- Reviewers
knauss - Commits
- R94:1e5bea9795a1: Merge Interface::MessagePart and MessagePart
Diff Detail
Diff Detail
- Repository
- R94 PIM: Message Library
- Branch
- review2
- Lint
No Linters Available - Unit
No Unit Test Coverage
messageviewer/src/messagepartthemes/default/plugins/messagepartrenderer.cpp | ||
---|---|---|
38 ↗ | (On Diff #20135) | useless now, because it is always a MimeTreeParser::MessagePart:) |
mimetreeparser/src/viewer/messagepart.h | ||
77 ↗ | (On Diff #20135) | doesn't it need to be virtual? |
150 | please keep them, these are for the new planned interface |
mimetreeparser/src/viewer/messagepart.h | ||
---|---|---|
150 | okay lets kill them for the moment |
mimetreeparser/src/viewer/messagepart.h | ||
---|---|---|
77 ↗ | (On Diff #20135) | virtual is inherited from QObject here. Technically this should be override, but override on dtors makes some compilers choke. |