Give legacy BPF::format() handling its own MessagePart sub-class
ClosedPublic

Authored by vkrause on Sep 30 2017, 8:40 AM.

Details

Summary

This allows us to remove all infrastructure needed for legacy handling
from the MessagePart base classes. Also, with Interface::MessagePart
vs MessagePart now no longer having any special meaning, we can merge
those two in a next step.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Sep 30 2017, 8:40 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 30 2017, 8:40 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added inline comments.Sep 30 2017, 12:10 PM
messageviewer/src/messagepartthemes/default/defaultrenderer.cpp
1057

should now be a qCWarning or a qCError, becauce this should never happen.

mimetreeparser/src/viewer/messagepart.h
118

add TODO: infront, so it is listed by kdevelop etc.

119

mark it as deprecated to make sure nobody using it for new code

mimetreeparser/src/viewer/objecttreeparser.cpp
219

not sure if we should try to move the complete handling into LegacyPluginMessagePart, to be able to cleanup OtP directly.

238

ignore the case when we get a Interface object, that sould result in an qCError. Sofar the Interface:MessagePart is still different from MesasgePart. okay handled in D8068

vkrause marked 3 inline comments as done.Sep 30 2017, 1:01 PM
vkrause added inline comments.
mimetreeparser/src/viewer/objecttreeparser.cpp
219

That would drag in more dependencies we don't want inside MessagePart, not worth it IMHO, it's just this single place now.

vkrause updated this revision to Diff 20149.Sep 30 2017, 1:03 PM

addressed review comments

knauss accepted this revision.Sep 30 2017, 1:08 PM

plaese do not commit before D8068 is ready too

This revision is now accepted and ready to land.Sep 30 2017, 1:08 PM
This revision was automatically updated to reflect the committed changes.