Differential D8046

[FrameSvgItem] Iterate child nodes properly
ClosedPublic
Actions

Authored by broulik on Sep 28 2017, 8:46 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:bb6b17051673: [FrameSvgItem] Iterate child nodes properly
Summary

Documentation says "Children are stored internally as a linked list, so iterating over the children via the index is suboptimal."

Test Plan

Verified that it doesn't crash and the number of repositioned nodes stays identical, ie. I didn't miss one.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 28 2017, 8:46 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptSep 28 2017, 8:46 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Sep 28 2017, 9:00 PM
This revision is now accepted and ready to land.Sep 28 2017, 9:00 PM
Closed by commit R242:bb6b17051673: [FrameSvgItem] Iterate child nodes properly (authored by broulik). · Explain WhySep 28 2017, 9:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20065

View Options

src/declarativeimports/core/framesvgitem.cpp

Loading...