Differential D8041

Use consistently "toolbar" in UI
ClosedPublic
Actions

Authored by kossebau on Sep 28 2017, 7:05 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R32:3228f40d0ead: Use consistently "toolbar" in UI

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 28 2017, 7:05 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 28 2017, 7:05 PM
kossebau added a comment.Sep 28 2017, 7:09 PM

‎[20:52] ‎<‎apol‎>‎ won't that break config entries?
‎[20:53] ‎<‎frinring‎>‎ uh, the i18n window title is used for config entries? let' see...
‎[20:55] ‎<‎frinring‎>‎ apol: grepping for windowTitle() I could not see a case where the string is used for config stuff, would that be some Qt internal state saving stuff?
‎[21:02] ‎<‎frinring‎>‎ grepping session data and kdeveloprc I also have no hit for "Tool Bar", so perhaps not. oh well, with people not around or lost connection, will dump into a full review request to put this on stash

Any can tell?

mwolff accepted this revision.Sep 28 2017, 8:09 PM
mwolff added a subscriber: mwolff.

grepping in my ~/.config doesn't bring up any match, so lgtm

This revision is now accepted and ready to land.Sep 28 2017, 8:09 PM
Closed by commit R32:3228f40d0ead: Use consistently "toolbar" in UI (authored by kossebau). · Explain WhySep 29 2017, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20068

View Options

kdevplatform/sublime/idealcontroller.cpp

Loading...