The current cmake files search for gnome keyring unconditionally, which on source-based distros would lead to a hard dependency on the package.
Hence, it would be a good idea to introduce an option to deactivate this if necessary.
Details
Details
- Reviewers
drosca - Group Reviewers
Falkon - Commits
- R875:75bd63ff2d56: Add option to deactivate searching for gnome keyring
Diff Detail
Diff Detail
- Repository
- R875 Falkon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Why is this needed? It is optional and used only for plugin (meaning if you build with gnome-keyring and run without it will just fail to load the plugin).
Comment Actions
The result of the build becomes unreproduceable, but depends on the availability of gnome-keyring instead.
Symmetry reasons might be another reason. It's possible controlling building of the KWallet plugin via CMAKE_DISABLE_FIND_PACKGE_KF5Wallet, but there's no way to do that for pkg_check_modules.