Differential D8013

Fix FrameSVGItem with the software renderer
AbandonedPublic
Actions

Authored by davidedmundson on Sep 27 2017, 2:36 PM.

Details

Reviewers
broulik
bcooksley
Group Reviewers
Plasma
Commits
R242:daef5c8b6b9c: Fix FrameSVGItem with the software renderer
Summary

Software rendering (at time of writing Qt5.10) doesn't seem to like our
tiling/stretching in the 9-tiles.
Also when using QPainter it's arguably faster to create and cache
pixmaps of the whole frame, which is what the slow path of FrameSVGItem
does.

Test Plan

Ran FrameSVG test then plasma shell with scene device set

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 27 2017, 2:36 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptSep 27 2017, 2:36 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik accepted this revision.Sep 27 2017, 2:46 PM
This revision is now accepted and ready to land.Sep 27 2017, 2:46 PM
Closed by commit R242:daef5c8b6b9c: Fix FrameSVGItem with the software renderer (authored by davidedmundson). · Explain WhySep 27 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.
bcooksley reopened this revision.Sep 29 2017, 8:37 AM
bcooksley added a subscriber: bcooksley.

Reopening - This breaks the build with Qt 5.7 based systems, which is the minimum requirement for Frameworks.

This revision is now accepted and ready to land.Sep 29 2017, 8:37 AM
bcooksley requested changes to this revision.Sep 29 2017, 8:37 AM
This revision now requires changes to proceed.Sep 29 2017, 8:37 AM
davidedmundson abandoned this revision.Sep 29 2017, 9:57 AM

Revision Contents
Changeset List

Diff 19990

View Options

src/declarativeimports/core/framesvgitem.cpp

Loading...