Differential D8005

static_cast QPlatformSurfaceEvent instead of dynamic_cast
ClosedPublic
Actions

Authored by broulik on Sep 27 2017, 10:19 AM.

Tags

Subscribers

apol, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R120:e79bf9e1949f: static_cast QPlatformSurfaceEvent instead of dynamic_cast

Summary

We check for QEvent::PlatformSurface so we can assume this is what we get.

Test Plan

Compiles, didn't notice anything unusual

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Sep 27 2017, 10:19 AM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 27 2017, 10:19 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested changes to this revision.Sep 27 2017, 1:04 PM

apol added a subscriber: apol.

apol added inline comments.

krunner/view.cpp
225	Then the if should be removed.

This revision now requires changes to proceed.Sep 27 2017, 1:04 PM

Drop if check

+1 lgtm

This revision is now accepted and ready to land.Sep 27 2017, 1:48 PM

Closed by commit R120:e79bf9e1949f: static_cast QPlatformSurfaceEvent instead of dynamic_cast (authored by broulik). · Explain WhySep 27 2017, 1:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krunner/view.cpp (4 lines)
M			ksmserver/shutdowndlg.cpp (20 lines)
M			ksmserver/switchuserdialog.cpp (20 lines)
M			shell/desktopview.cpp (20 lines)
M			shell/panelconfigview.cpp (40 lines)
M			shell/panelview.cpp (22 lines)

Diff 19980

krunner/view.cpp

Loading...

ksmserver/shutdowndlg.cpp

Loading...

ksmserver/switchuserdialog.cpp

Loading...

shell/desktopview.cpp

Loading...

shell/panelconfigview.cpp

Loading...

shell/panelview.cpp

Loading...